Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipywidgets_bokeh documentation #9590

Merged
merged 2 commits into from Jan 27, 2020
Merged

Add ipywidgets_bokeh documentation #9590

merged 2 commits into from Jan 27, 2020

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Jan 20, 2020

No description provided.

@mattpap mattpap force-pushed the mattpap/ipywidgets_bokeh_docs branch from 0af12bc to cc19617 Compare Jan 20, 2020
@bryevdv
Copy link
Member

@bryevdv bryevdv commented Jan 20, 2020

We should not have separate Notebook and Jupyter chapters (there are already too many chapters). If we need to re-name the Notebook chapter to something more general, now (2.0) is the time to do it. But I'd suggest leaving a page at the Notebook URL that links back the new Jupyter chapter.

@mattpap
Copy link
Contributor Author

@mattpap mattpap commented Jan 20, 2020

I think it would be confusing to merge those. I split it off intentionally, to make it clear that this isn't notebook related. I also didn't see it fit under other sections (embedding, server, etc.). I think it's not that bad to have many sections, compared to nested structure.

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Jan 20, 2020

I personally think the opposite, that people would expect and be better served by having everything Jupyter-related (which includes: notebooks, jupyterlab, and ipywidgets) in one place rather then multiple.

cc @bokeh/dev

@philippjfr
Copy link
Contributor

@philippjfr philippjfr commented Jan 20, 2020

Honestly I can see both arguments, if you want to merge them I also suggest calling it the Jupyter chapter and linking back to it from the old Notebook URL link.

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Jan 20, 2020

I also think that 10 sentences does not comprise enough material for a dedicated chapter.

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Jan 20, 2020

Additionally: Having a chapter called "Jupyter" that does not cover Jupyter Notebooks is absolutely confusing.

I still 1000% think that these chapters should be merged, but if they are not to be merged, I must insist that the chapter be renamed to "Ipywidgets" which is actually descriptive of the content, and not confusingly called "Jupyter" while excluding the singular thing that everyone associates with that name (notebooks).

Edit: Even better: rename it "Ipywidgets" and add it as a sub-chapter under "Adding Interactions". Everything else about widgets / UI is under "Adding Interactions". As a sub-chapter it has a reasonable length.

@bryevdv bryevdv merged commit 93feec2 into master Jan 27, 2020
19 checks passed
@bryevdv bryevdv deleted the mattpap/ipywidgets_bokeh_docs branch Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants