Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofac Dependency should be in another package #25

Closed
BlowaXD opened this issue Mar 29, 2020 · 4 comments · Fixed by #26
Closed

Autofac Dependency should be in another package #25

BlowaXD opened this issue Mar 29, 2020 · 4 comments · Fixed by #26

Comments

@BlowaXD
Copy link

BlowaXD commented Mar 29, 2020

Hi,

You recently decided to provide easy DI for your package, the thing is, you provided your package with direct dependency of AutoFac on version 2.0+

Do you think you can split the AutoFac DI extensions to another package ? like dotenv.net.AutoFac

Thanks for your library.

@bolorundurowb
Copy link
Owner

Thanks @BlowaXD , I see the point you are making and would get right on that

@BlowaXD
Copy link
Author

BlowaXD commented Mar 31, 2020

Thanks 😊
It was mostly because I'd like to reduce the size of my docker images but I still want to use your library.

@bolorundurowb
Copy link
Owner

These are the DI packages @BlowaXD
https://www.nuget.org/packages/dotenv.net.DependencyInjection.Microsoft
https://www.nuget.org/packages/dotenv.net.DependencyInjection.Autofac/

@BlowaXD
Copy link
Author

BlowaXD commented Apr 2, 2020

Thanks gonna update it tonight :) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants