Fix sinatra/json error by re-adding sinatra-contrib

[trueheart78]

In #22 the sinatra-contrib gem was replaced with sinatra, but that did not take into account that sinatra-contrib is required for the require 'sinatra/json' in lib/sinatra/stoplight_admin.rb. See the Sinatra::JSON (part of Sinatra::Contrib) for details.

@bolshakov Could you take a look at this? Maybe there is a simple way to add specs to help with the altering of the required gems to keep things like this from happening in the future? I'd be glad to assist with that, if needed.

[bolshakov]

Yeah, we need at least smoke tests to be able to catch such simple cases. Let's add tests first and then merge your PR?

Yeah, we need at least smoke tests to be able to catch such simple cases. Let's add tests first and then merge your PR?

I'll try to add some tests on the weekend.

[trueheart78]

Sounds like a plan. I might have time before then to work on it. Is there a preference for a particular testing framework? I'm fine with both minitest and rspec.

[bolshakov]

That would be very helpful! I'd suggest using rspec to be consistent with Spotlight

[trueheart78]

This is ready for review. Feel free to make any changes that you might see fit. You can verify the spec passes if you change the sinatra-contrib line in the gemspec file to sinatra and re-bundle and re-run the spec.

I hope this helps out.

[trueheart78]

@bolshakov I hope everything looks good. Will you have time soon to review?

[trueheart78]

@bolshakov We're trying to finalize our Rails upgrade and I just wanted to check in again. I don't mean to pester, as I know you are busy.

[bolshakov]

@trueheart78 that's a good start, thanks 👍

[bolshakov]

https://rubygems.org/gems/stoplight-admin/versions/0.3.5 released