Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @bolt/build-tools to skip Bolt version check during non-prod builds #949

Merged
merged 1 commit into from Nov 18, 2018

Conversation

sghoweri
Copy link
Contributor

@sghoweri sghoweri commented Nov 9, 2018

Jira

N/A

Summary

Defers running the check for available Bolt versions (the info that we display in the new version selector) if the build isn't being run in prod mode -- speeds up the initial boot up process when doing local dev work so no-one has to wait around unnecessarily.

How to test

  • Confirm version selector logic continues to work on the staged version of the Bolt site (prod mode)
  • Confirm that locally the check for Bolt versions that are available runs almost instantly (dev mode)

…ll available Bolt versions — speeds up initial boot up process when doing local dev work
@bolt-bot
Copy link
Collaborator

bolt-bot commented Nov 9, 2018

⚡ PR built on Travis and deployed a now preview here:

Copy link
Collaborator

@mikemai2awesome mikemai2awesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, it's good.

@sghoweri sghoweri changed the base branch from master to release/2.x November 16, 2018 20:47
@sghoweri sghoweri merged commit 73f6fd1 into release/2.x Nov 18, 2018
@sghoweri sghoweri deleted the feature/skip-version-check-on-dev branch November 18, 2018 13:31
@sghoweri sghoweri mentioned this pull request Nov 18, 2018
adamszalapski added a commit that referenced this pull request Jan 24, 2019
affects: @bolt/components-ol, @bolt/components-ul

ISSUES CLOSED: #948, #949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants