Check if session is started before accessing #35

Merged
merged 2 commits into from Dec 27, 2016

Projects

None yet

2 participants

@GawainLynch
Member

No description provided.

@CarsonF
Member
CarsonF commented Dec 22, 2016

That voids the check completely.

@GawainLynch
Member

Yeah, hold this.

@GawainLynch
Member

@CarsonF I have 🐒 tested this and it seems to work as expected, i.e. if a session cookie is present in the initial request, the session will be restarted so this check is actually valid.

I have updated the tests as such, and covered off the deprecated use of $this->getMock() in the process.

@CarsonF
Member
CarsonF commented Dec 27, 2016

Ah! Because session listener starts the session if precious exists.

@CarsonF
Member
CarsonF commented Dec 27, 2016

Can you remove the isset around session check? It's very non intuitive IMO

@GawainLynch
Member

Can you remove the isset around session check? It's very non intuitive IMO

Ha! I can't believe I missed that … Done!

@CarsonF CarsonF merged commit 9ec3f4d into bolt:master Dec 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GawainLynch GawainLynch deleted the GawainLynch:hotfix/session branch Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment