Added Save button in Live editor, fixes #6161 #6178

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@roggan87
Contributor

This PR adds a simple save button right in the Live editor top menu. The button extracts the values from contentEditables and "clicks" on the #savecontinuebutton. If the record exists, the Live editor will stay open (and the button itself indicate that saving happens the same way as the usual save button). If the record doesn't exist, the page will reload which makes the Live editor close.

Fixes: #6161

@bobdenotter
Member

Hi @roggan87, Could you remove the built assets from this PR? They tend to conflict, when merging across branches. Specifically yo.min.js, bolt.js, bolt.css and lib.js. :-)

@roggan87
Contributor

Of course! I thought it was a bit strange that they were included, but I'll remove them.

@roggan87
Contributor

Now I removed them with git rm. Is that the preferred way or should I revert and just not include them in the original commit?

@GawainLynch
Member

What you need to achieve is to not have the built assets as part of any commit in your branch to PR.

If you're git is up to it, then you can rebase from 5263763, reverts the diff to those files and drop the second commit. Call out if you need help/handover 👍

@GawainLynch
Member

Decided to go the easy route, and merged via fe9382f

@roggan87
Contributor

Thanks! I'll keep that in mind the next time.

@GawainLynch
Member

Zero stress … we don't actually have this documented well enough, so largely our fault too.

When a project is managing just one branch, it makes very little difference (still makes selective reverts harder, but not too bad). Whereas we have the stable, beta, alpha, 3.x (pre-alpha), and 4.x (master) branches so the merges can get fun 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment