New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opt in to new setcontent queries #6622

Merged
merged 10 commits into from Aug 1, 2017

Conversation

Projects
None yet
4 participants
@rossriley
Contributor

rossriley commented May 5, 2017

As previously discussed this uses the new compatibility section in config.yml to switch from the current to the new getContent query engine.

Note that this is definitely not ready for use by anyone other than core developers at the moment, but it will allow us to spot and fix any incompatibilities as we go through the 3.4 development period.

It is envisaged that all this code will be removed in version 4 assuming that the inconsistencies can be ironed out.

@GawainLynch GawainLynch requested review from GawainLynch and CarsonF May 5, 2017

Show outdated Hide outdated src/Controller/Base.php Outdated
Show outdated Hide outdated src/Twig/Extension/BoltExtension.php Outdated
@CarsonF

Do we really need to change/add a new twig node? Why can't we just do that check inside BoltExtension::getContent?

Show outdated Hide outdated app/config/config.yml.dist Outdated

@GawainLynch GawainLynch added this to the Bolt 3.4 - Feature release milestone May 9, 2017

@CarsonF

We don't need the extra twig node and parser version.

@bobdenotter

This comment has been minimized.

Show comment
Hide comment
@bobdenotter

bobdenotter Jun 12, 2017

Member

Once this lands, we effectively have solved #6530 too, right?

Member

bobdenotter commented Jun 12, 2017

Once this lands, we effectively have solved #6530 too, right?

@GawainLynch

This comment has been minimized.

Show comment
Hide comment
@GawainLynch

GawainLynch Jun 13, 2017

Contributor

Once this lands, we effectively have solved #6530 too, right?

Didn't #6443 took care of that?

Contributor

GawainLynch commented Jun 13, 2017

Once this lands, we effectively have solved #6530 too, right?

Didn't #6443 took care of that?

@bobdenotter

This comment has been minimized.

Show comment
Hide comment
@bobdenotter

bobdenotter Jun 13, 2017

Member

Didn't #6443 took care of that?

Yes. :-)

Member

bobdenotter commented Jun 13, 2017

Didn't #6443 took care of that?

Yes. :-)

@GawainLynch

This comment has been minimized.

Show comment
Hide comment
@GawainLynch

GawainLynch Jul 18, 2017

Contributor

@rossriley 3.4 is due to start beta phase on the 25th. How is progress on this coming?

Contributor

GawainLynch commented Jul 18, 2017

@rossriley 3.4 is due to start beta phase on the 25th. How is progress on this coming?

@GawainLynch GawainLynch changed the base branch from release/3.4 to 3.4 Jul 25, 2017

@GawainLynch GawainLynch reopened this Jul 25, 2017

@rossriley rossriley dismissed stale reviews from GawainLynch and bobdenotter via 50f404f Jul 25, 2017

Request changes implemented

@GawainLynch

This comment has been minimized.

Show comment
Hide comment
@GawainLynch

GawainLynch Aug 1, 2017

Contributor

:shipit:

Contributor

GawainLynch commented Aug 1, 2017

:shipit:

@GawainLynch GawainLynch merged commit 8841e59 into bolt:3.4 Aug 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment