New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] More Symfony Forms updates #6766

Merged
merged 14 commits into from Jul 6, 2017

Conversation

Projects
None yet
2 participants
@GawainLynch
Contributor

GawainLynch commented Jun 20, 2017

Talk about a 5 minute fix that took three weeks to get over the line 😞

OK, so this PR:

  • Implements SF forms for file editing
  • Implements SF forms for file upload form
  • Starts the implementation of SF Forms for content editing πŸŽ‰
    • <form> & </form>
    • Most buttons
    • Not fields … yet! Another PR, and a big lot of work
  • Fixes a bug that prevents multiple buttons from being distinguished
  • Migrate the base form to SF's bootstrap_3_horizontal_layout.html.twig template as a starting point, removing a lot of crud from ours
  • The "Duplicate {ContentType}" link in listings will now take you to a new edit page, with the copied content rather than the edit page of the original
  • Most useless fragment are gone from editing URLs … some I couldn't find … yet
  • Cleans up an utter truck load of jQuery selectors in the areas I was touching …
    • Rage Level 11 πŸ˜‰
    • Temptation to not rip the whole layer out while I was there … strong! πŸ˜‰
  • Legitimate JavaScript errors we want included on console, will now appear on the console and not removed by ESLint … ones we do not need, πŸ”₯

GawainLynch added some commits Jun 13, 2017

Adjust JavaScript for content editing form changes
… and clean some crap up!

@GawainLynch GawainLynch added this to the Bolt 3.4 - Feature release milestone Jun 20, 2017

@bobdenotter bobdenotter merged commit 8c3e027 into bolt:release/3.4 Jul 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GawainLynch GawainLynch deleted the GawainLynch:hotfix/form-template-overrides branch Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment