Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[3.4] Implement use of bolt/common #6892
Good start :)
- There's lots of places
Json::parse()is called with a second parameter that is not needed.
- There are places
Json::dump()is called with
0, but probably could be fine with some options. I understand some places don't make sense for pretty print, but I don't see why we need to escape slashes or unicode.
- Str has those two methods that are BC breaks. I think it might be better to trigger deprecation warnings for each method call instead of the file. That was it is easier to find usages that need to be fixed.
I knew this would come up, was waiting to see what/how
I mean JSON shouldn't be programmatically inspected, it should just be parsed. The only exception, I think, would be test assertions. So regardless of the dump flags, the output should be valid JSON which can be parsed anywhere. Now with that said, I know pretty printed can make things less readable for small data and increases size which should only matter when it is being transported over the wire. HTML might have a problem with unescaped unicode, that should be double checked...I'm still drinking
OK! This should be good to go, and our combined hashing out of the JSON parameters should have both our O.C.D. triggers covered
Unless you have derps to point out, lets as by the time you're online today I'll be about to go offline, and we lose you over the weekend. I want to tie up the last of the beta work over the weekend & Monday EU time as @bobdenotter will be back as well.