New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] PHP 7.2 support #6920

Merged
merged 7 commits into from Aug 21, 2017

Conversation

Projects
None yet
1 participant
@GawainLynch
Contributor

GawainLynch commented Aug 21, 2017

This is the first part of support for PHP 7.2.

First commit is a cherry-pick of the one that went to master in November last year (the JFK PR) that allows us to run PHPUnit 4.8 and/or 5.7, as \PHPUnit_Util_Getopt uses each() in versions prior to 5.0 that causes PHPUnit to fatal with E_ALL on.

There is then some tweaks & clean up to tests … nothing much to see really.

Finally the last commit, as per the commit message, just puts a couple of safety blankets around the use of count() as in PHP 7.2 it will now emit warnings, that are converted to exceptions with debugging on, preventing a default install from booting.

This by no means is the end of this work, but I am sending this part in now to get/keep coverage going as I work on getting 3.4 ready for release.

GawainLynch added some commits Nov 24, 2016

@GawainLynch GawainLynch added this to the Bolt 3.4 - Feature release milestone Aug 21, 2017

@GawainLynch GawainLynch merged commit 651eed1 into bolt:3.4 Aug 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GawainLynch GawainLynch deleted the GawainLynch:hotfix/php-72 branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment