New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Add "embed" field type #7278

Merged
merged 5 commits into from Dec 31, 2017

Conversation

Projects
None yet
3 participants
@GawainLynch
Contributor

GawainLynch commented Dec 31, 2017

Someone … somewhere … wanted this 😉

Closes #6928
Closes #6292

GawainLynch and others added some commits Dec 4, 2017

@bobdenotter

Works as described, for me. Will need some field-testing and documentation, but let's :shipit:

@bobdenotter bobdenotter merged commit 4c90eca into 3.5 Dec 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bobdenotter bobdenotter deleted the feature/embed-field-type branch Dec 31, 2017

@ToBe998

This comment has been minimized.

Contributor

ToBe998 commented Feb 5, 2018

Just a small note as i stumbled over this too. The values a oEmbed service returns are completely proprietary. The only thing that "most" services share is the html field, but even this isnt available in general.
So, a field like this will only work if there is some configurable/extendable per-service logic to generate the html embed block. One size-fit's-all is sadly not possible with oEmbed.

@GawainLynch

This comment has been minimized.

Contributor

GawainLynch commented Feb 5, 2018

Yes, that is correct. But what the embed/embed library does give us is an interface that we can use that gives us some fields, so that is what we ran with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment