New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a viewless (singleton) contenttype for `homepage: …` setting #7372

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
2 participants
@bobdenotter
Member

bobdenotter commented Mar 13, 2018

If you have a homepage contenttype, like this:


homepage:
    name: Homepage
    singular_name: Homepage
    fields:
        …
    viewless: true
    singleton: true

setting homepage: homepage/1 will not work, because the homepage() controller doesn't fetch a viewless contenttype. This PR allows you to use a viewless contenttype as a homepage.

@GawainLynch GawainLynch merged commit 4db3801 into 3.4 Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GawainLynch GawainLynch deleted the hotfix/allow-viewless-homepage branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment