Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs: how2 use collection with same functionality as repeater #1055

Closed
surips opened this issue Feb 11, 2020 · 18 comments
Closed

Update docs: how2 use collection with same functionality as repeater #1055

surips opened this issue Feb 11, 2020 · 18 comments

Comments

@surips
Copy link

surips commented Feb 11, 2020

I have a repeater in my contenttype in Bolt v3 like so:

        features:
            type: repeater
            fields:
                title:
                    type: text
                image:
                    type: image
                    extensions: [ gif, jpg, png ]
                teaser:
                    type: text
                    class: large
                content:
                    type: html   

Thereby in my contenttype I can add a new feature which includes a title, an image, a teaser and content.
Now, I would like to have the same in v4, but I saw that repeaters do not longer exist. I tried to achieve the same functionality by changing the type from repeater to collection. But then, I can only add the different fields one by one and that is not what I want. I would like to have the exact same functionality of a repeater of v3 in v4. Do I need to use a set? I did not find an example how to do this in the docs.

Thank you in advance

@panda-madness
Copy link

panda-madness commented Feb 12, 2020

I haven't played around with Bolt 4 yet, but skimming through the docs I imagine you're supposed to make a collection of set fields, something along the lines of:

        features:
            type: collection
            fields:
                content:
                    type: set
                    fields:
                        title:
                            type: text
                        image:
                            type: image
                            extensions: [ gif, jpg, png ]
                        teaser:
                            type: text
                            class: large
                        content:
                            type: html   

You can add more than 1 set field to mimick the old named repeater functionality, or just add 1 for a regular repeater.

@bobdenotter
Copy link
Member

bobdenotter commented Feb 13, 2020

@panda-madness Nailed it! 👍

Basically, to replicate the old 'repeater' behaviour, you can wrap the fields in a type: set. Does that make sense? (asking so i can make sure the docs are clear, when I write them)

@surips
Copy link
Author

surips commented Feb 13, 2020

I tried @panda-madness suggestion and inserted it into my contenttypes.yaml. On first glance it seemed to have worked, as I could input my content like I wanted. But when I clicked on the save button a ForeignKeyConstrainViolationException occured: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails.

I still can save my progress on other contenttypes, but not on this one. Do you have any idea why this exception occured and how I can fix it?

@bobdenotter
Copy link
Member

bobdenotter commented Feb 13, 2020

@surips More information, please.. Read this: https://bolt.tips/entry/reporting-issues-effectively

@surips
Copy link
Author

surips commented Feb 13, 2020

Yes, sorry. Again:
So I inserted this into my contenttype in my contenttypes.yaml:

        slides:
            type: collection
            fields:
                content:
                    type: set
                    fields:
                        firsttext:
                             type: text
                        firstimage:
                             type: image
                        secondtext:
                             type: text
                        secondimage:
                             type: image

As I mentioned before, this seemed to work, because I was able to use it and input content, as if it was a repeater, just like I wanted. But when I wanted to save the new content the exception occured (after clicking on the save button). I will enclose a screenshot of the exception. Do you need any more information? As mentioned I am on v4.0.0

ForeignKeyConstraintViolationException

@bobdenotter
Copy link
Member

bobdenotter commented Feb 13, 2020

@surips Thanks.. Additional question: What's the output of bin/console bolt:info ?

@surips
Copy link
Author

surips commented Feb 13, 2020

@bobdenotter This:
screenshot

@wgaulke
Copy link

wgaulke commented Feb 17, 2020

Update regarding the issue: We dropped and recreated the database after Update to RC3.

The issue still remains. However, the first entry can be made. Only, when editing the collection and saving it again the error occurs.
I know, we should not be guessing, but it looks like the collection elements are dropped and reinserted on save and the ordering of queries seems to be off so that the FK_constraint kicks in.

@bobdenotter
Copy link
Member

bobdenotter commented Apr 13, 2020

@surips @wgaulke

I've been trying to confirm this report, but so far i haven't succeeeded. My contenttype:

dummies:
    name: Dummies
    singular_name: Dummy
    fields:
        title:
            type: text
        slug:
            type: slug
            uses: title
        veld:
            type: textarea
        slides:
            type: collection
            fields:
                content:
                    type: set
                    fields:
                        firsttext:
                            type: text
                        firstimage:
                            type: image
                        secondtext:
                            type: text
                        secondimage:
                            type: image
    icon_many: "fa:viruses"
    icon_one: "fa:virus"

And my bolt:info

 Bolt version: 4.0.0 RC 15

 * Install type: Git clone
 * Database: mysql 5.7.26 - 127.0.0.1 via TCP/IP (with JSON)
 * PHP version: 7.2.21
 * Operating System: Darwin - 18.7.0

I can add, save, delete, save again.. Seems to work as expected. I do think my colleague fixed an ussie with foreign keys a while ago, so it just might've been fixed in the mean time.. I'll leave this open for now until either you confirm it's working now, or until I can reproduce it as an error. :-)

@JTNMW
Copy link
Contributor

JTNMW commented Apr 15, 2020

I've been experiencing the same issue with collections and sets on mysql, encountering foriegn key update/delete constraints when updating a record with a collection containing field sets.

I resolved the issue by changing the Index affected from restrict to cascade via phpmyadmin.
from:
.
image
to:
Screenshot 2020-04-15 at 14 15 32

is there a preferred/recommended fix other than this?

@surips
Copy link
Author

surips commented Apr 21, 2020

@bobdenotter For the first release we have chosen to leave this functionality out, due to the exception. But we will probably integrate it soon for future releases, so I'll keep you updated :-)

@bobdenotter
Copy link
Member

bobdenotter commented Apr 21, 2020

@surips Sure thing, we'll leave this one open, and if new information comes to light, we'll fix it if needed. :-)

@bobdenotter
Copy link
Member

bobdenotter commented Apr 21, 2020

@JTNMW,

I resolved the issue by changing the Index affected from restrict to cascade via
phpmyadmin. from:

The annotations around the definition of that field does allow us to tweak its behaviour:

https://github.com/bolt/core/blob/master/src/Entity/Field.php#L73-L76

    /**
     * @ORM\ManyToOne(targetEntity="Bolt\Entity\Field", cascade={"persist"})
     */
    private $parent;

Maybe one of the different options for persist would work better?

@JTNMW
Copy link
Contributor

JTNMW commented Apr 21, 2020

After a fresh project setup with 4.0.0.rc17 and MYSQL, and with the following collection + set added to the pages contenttype.yaml

fields:
  publications:
            type: collection
            collapsible: true
            label: Publications
            group: Selected Publications
            fields:
               publication:
                  type: set
                  label: Publication
                  fields:
                    publication:
                      type: html
                    resource:
                      type: file

I am able to add, edit and delete sets in the collection and save the parent record.

However, foreign key constraint still happens if i try to delete the parent record if it contains child records in the collection/sets fields.

I tried changing the 'cascade={"persist"}' (adding "remove") without success. Foriegn key problem is still occuring.

I have found that adding this to the field.yaml L#73 before the running bolt:setup sets the "on Delete" to CASCADE for the relation and the foreign key issue is resolved.

 /**
     * @ORM\ManyToOne(targetEntity="Bolt\Entity\Field", cascade={"persist"})
     * @ORM\JoinColumn(onDelete="CASCADE")
     */
    private $parent;

Having "on delete" set to CASCADE brings the foreign key relationship in line with the "Taxonomy" and "Relations" tables of the DB.

I havent ome across any conflicts having the database schema set like this.

Please try include the Collections/set (ie repeater from bolt 3) in the stable version. It is much needed feature.

@bobdenotter
Copy link
Member

bobdenotter commented Apr 21, 2020

Having "on delete" set to CASCADE brings the foreign key relationship in line with the "Taxonomy" and "Relations" tables of the DB.

That makes sense. Would you like to make a small PR to effect that change? That way you'll get "credits" for the fix.

Please try include the Collections/set (ie repeater from bolt 3) in the stable version. It is much needed feature.

The new collections are intended as a superset of the old repeaters/blocks from V3. I'm aware I need to write docs for it though.

Is there anything in specific you're trying to do with it, that you can't manage in v4? I'll happily provide some help to get it working! :-)

@surips
Copy link
Author

surips commented Jun 25, 2020

@bobdenotter Just wanted to let you know, that I have tried out the Collection / Set combo to replace a Repeater and it works! :)

@bobdenotter
Copy link
Member

bobdenotter commented Jun 25, 2020

@surips Good to hear! Thanks for the feedback.

@I-Valchev
Copy link
Member

I-Valchev commented Aug 19, 2020

This was fixed in documentation: bolt/docs#1052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants