Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] adding admin user relies on exec, shell_exec #1461

Open
peterboorsma opened this issue Jun 9, 2020 · 6 comments
Open

[Question] adding admin user relies on exec, shell_exec #1461

peterboorsma opened this issue Jun 9, 2020 · 6 comments

Comments

@peterboorsma
Copy link
Contributor

peterboorsma commented Jun 9, 2020

The bin/console bolt:add-user --admin command line relies on exec and shell_exec. My guess is a lot of (shared) hosting providers have these options disabled by default.

I don't know much about PHP settings and server security , so I do not know if it is save to enable these commands but does this mean that some (a lot?) of users can't use Bolt4?

@bobdenotter
Copy link
Member

bobdenotter commented Jun 10, 2020

What error are you getting exactly, if it's not there?

I'm not sure we can make that optional, as both Composer and Symfony itself rely on it as well.

@peterboorsma
Copy link
Contributor Author

peterboorsma commented Jun 10, 2020

I recently updated to PHP 7.3 on my server. I think both exec and shell_exec are disabled by default, so I changed this in the php.ini after I ran into this error.
When I tried adding a new admin user, by the time a password is being generated, the following error appears in an endless loop:
[ERROR] Warning: exec() has been disabled for security reasons

It's not a problem for me personally but I think it's a good idea that this is mentioned in a "system requirements" paragraph in the docs. I know you are still working on the docs btw. ;)

@bobdenotter
Copy link
Member

bobdenotter commented Jun 10, 2020

It's not a problem for me personally

As in: After you were getting that error, you enabled it, and then it was smooth sailing? :-)

@peterboorsma
Copy link
Contributor Author

peterboorsma commented Jun 10, 2020

Yes. Enabled them, restarted PHP. Problem solved.

@bobdenotter
Copy link
Member

bobdenotter commented Jun 11, 2020

Ok, will add to docs!

@I-Valchev
Copy link
Member

I-Valchev commented Sep 1, 2020

Let's bump this to 4.1 for now

@I-Valchev I-Valchev modified the milestones: Bolt 4.1, 🔥 Backburner Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants