Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ Make "Fieldsets" work (to replace both 'blocks' and 'repeaters') #176

Closed
bobdenotter opened this issue Nov 29, 2018 · 9 comments
Closed

Comments

@bobdenotter
Copy link
Member

No description provided.

@bobdenotter
Copy link
Member Author

When implementing this, don't forget to make it work in _sub_fields.twig as well.

@sbonardt
Copy link
Contributor

sbonardt commented Oct 21, 2019

The name 'fieldset' for me is too much tied to a form to use it as a field type name. Other suggestions:

'field groups', 'field collections', or 'grouped fields'

@bobdenotter
Copy link
Member Author

bobdenotter commented Nov 15, 2019

"Groups" is already used to refer to groups of fields shown on one 'tab' in the editors, so that's confusing too.

    fields:
        title:
            type: text
            group: Text

@sbonardt
Copy link
Contributor

sbonardt commented Nov 15, 2019

@bobdenotter So shouldn't "group" be renamed to "tab" then...? To keep things logical. Now you assign fields to a certain "group" to have them show up in a certain "tab". Assigning a field to a certain "tab" to have them in a certain "tab" in the UI sounds good to me. And then you can use "group" to group fields. Or "fieldgroup"

@bobdenotter
Copy link
Member Author

bobdenotter commented Nov 15, 2019

A tab is "what it looks like", not "what it is". It feels kinda like <div class="red"> to do that.

@sbonardt
Copy link
Contributor

sbonardt commented Nov 15, 2019

If you want to name it what it is, then just rename "group" to "fieldset". But this is UI for the end user, and that person sees a "tab".

Any way, you get to use "group" for the group of fields

@bobdenotter
Copy link
Member Author

I think i'm more in favor of your other suggestion: Name the replacement for Blocks and Repeaters "Collection", and leave 'group' as is.

@bennash
Copy link

bennash commented Nov 17, 2019 via email

@I-Valchev I-Valchev mentioned this issue Nov 25, 2019
@bobdenotter
Copy link
Member Author

Closing, because the feature has been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants