-
Notifications
You must be signed in to change notification settings - Fork 177
Maintenance Mode is active even if the user is logged in #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've been thinking about this, and i'm not entirely sure we should "fix" this. If an authenticated user can see the site while it's in maintenance mode, i'm positive a lot of people will be putting their sites in maintenance mode, and then forgetting to turn if off because thhey can just see the frontend. Fixing this itself won't be hard (add a check for a user in For now, you can use the "preview" option from the backend to view single pages, whilst maintenance is on. |
Sure that is an option for now. As a recommendation I would suggest solving this need to make it visible by adding something like the "edit-this-page"-Button from Ivo's extension to the page. Like a big "MAINTENANCE" in red letters at the lower right corner or something should do the trick in my opinion. |
We can also use the configuration notices to warn admins that the site is in maintenance mode. When we think about this more on 4.1, should we allow an option for admins to get out of maintenance mode without having to ssh to the server to edit the config? |
It is in configuration notices, but not everybody will have that installed. From the v3 days, I know that a bunch of developers will actively want to remove it, because they feel they don't need it. (which is true, until they do ;-) ) |
Just joining with my opinion here (as I was affected by this today), a reason I would want to put a site in maintenance mode is because I want to make changes (new content, re-arrange content, apply updates, etc.) without this being visible to external users. If I cannot see my site whilst it's in mainenance mode, there is no way I can test the site is working after an upgrade, or my content is linked and appearing correctly, without putting it live for everyone. Also the comment in the default
Drupal sorts the issue of the admin not realising the site is in maintenance by putting a banner on every page - whether it's in the admin, or on the front-end of the site, so there is no way you can miss it. Also to @I-Valchev:
Admins can amend this using the config editor for |
This was fixed in #2376 |
If I active maintenance mode (maintenance_mode: true in config.yaml) this maintenance page is visible for everyone (logged in or not) instead of being just visible to users that are not logged in.
Details
The text was updated successfully, but these errors were encountered: