Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make replaceable admin theme (with docs how to overwrite any part of it) #196

Open
nestordedios opened this issue Nov 30, 2018 · 6 comments
Open

Comments

@nestordedios
Copy link
Collaborator

@nestordedios nestordedios commented Nov 30, 2018

No description provided.

@sbonardt
Copy link
Contributor

@sbonardt sbonardt commented Jun 24, 2019

Let's focus on the main admin theme in place first, working to a nice and well designed backend for Bolt 4. After this is in place we can work on themable stuff

Loading

@JarJak
Copy link
Member

@JarJak JarJak commented Jun 28, 2019

@sbonardt but then it can be hard to make it decoupled, isn't it?

Loading

@sbonardt
Copy link
Contributor

@sbonardt sbonardt commented Jun 28, 2019

@JarJak I don't understand. Do you mean if the admin theme is not replaceable its hard to make it decoupled? How? We did leave the theming option in for now, but for the base styling of the backend we now work to a base look and feel. That can be overridden by a (default/custom) theme (css) but that file we now have left blank intentionally.

First get something in place that is usable, validates and looks nice. I belive we can enhance that i a simpler way to a themable solution than whats in place now. I'm happy to discuss and get shown otherwise if I'm missing something.

Loading

@JarJak
Copy link
Member

@JarJak JarJak commented Jul 3, 2019

@sbonardt because when you don't design your code first, it's hard to redesign it later. But if it will be possible to override only only css, but also js and twig, I'm fine with it. Also this task can be moved to, like, Bolt 4.1.

Customizing admin panel in Bolt 3 was a really painful thing.

Loading

@sbonardt
Copy link
Contributor

@sbonardt sbonardt commented Jul 4, 2019

@JarJak Ah, ok, now I understand you correctly. Yes, I can imagine and that's exactly the intention for V4: make the backend easier to style and code frontend wise and clean stuff up. That's why I picked up the rework issue and implemented start for a mobile first, responsive structure. For now that is just the structure, not the look and feel. I'm striving to first work to a clean, logical structural setup first with a well a good pproach for the code as well for maintainability but also for adopting or hooking into existing classes and styles, or subsequently overriding them.

I agree customising the admin panel was a painful thing, but then again I need to check with @bobdenotter to what extent we would like people to be able to adjust the backend design and look and feel in V4, and work from there.

Loading

@bobdenotter bobdenotter removed this from the Bolt 4 beta 4 milestone Sep 28, 2019
@bobdenotter bobdenotter added this to the 🔥 Backburner milestone Sep 28, 2019
@bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Sep 28, 2019

Bumping this to a later version. If there's a valid usecase, we can bump it higher on the priority list again.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants