Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accesibility] Add accessible names to checkboxes #2177

Open
Chi-teck opened this issue Nov 26, 2020 · 3 comments
Open

[accesibility] Add accessible names to checkboxes #2177

Chi-teck opened this issue Nov 26, 2020 · 3 comments

Comments

@Chi-teck
Copy link

Details

Currently checkbox in admin listings are rendered with empty labels.
https://github.com/bolt/core/blob/4.1/assets/js/app/listing/Components/Filter.vue#L8

That leads to bad accessibiltiy.

Question Answer
Relevant Bolt Version 4.1
Install type Composer install
BC Break no
PHP version 7.4
Web server Nginx
For UX/UI issues Google Chrome

Proposed solution

Add accessible names and apply "visually-hidden" class to these labels.
Something like this

<label class="visually-hidden">Select all</label>
@Chi-teck Chi-teck changed the title [accesibility] Add accessible names to checkbox [accesibility] Add accessible names to checkboxes Nov 26, 2020
@I-Valchev I-Valchev added this to the Editor Accessibility milestone Nov 26, 2020
@I-Valchev
Copy link
Member

Hi @Chi-teck , nice catch and tracking the source of the issue.

Can I assign this issue to you? :-)

@Chi-teck
Copy link
Author

@I-Valchev I am not quite familiar with Bolt internals to fix this properly.

@DorienD
Copy link
Contributor

DorienD commented May 19, 2021

This is fixed in: #2545. Not sure why that doesn't pop up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants