Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two issues with `multiselect` #223

Closed
bobdenotter opened this issue Dec 22, 2018 · 2 comments

Comments

@bobdenotter
Copy link
Member

commented Dec 22, 2018

The new "multiselect" items work, but there are some missing bits to make them fully useable:

        <editor-select
            :value="'{{ value }}'".  <- There
            :name="'{{ name }}'"
            :id="'{{ id }}'"
            :options="{{ options|json_encode() }}"
            :form="'{{ form }}'"
        ></editor-select>
  1. You can pass in a single value like books or movies and it works. It seems like you can't pass in an array like ["books", "movies"] to select 2 initially.

  2. Selected values don't persist when POSTing. You can select items, but these aren't included when the form is submitted

  3. There's an odd empty initial selection:

screenshot 2018-12-22 at 12 56 48

@jackiboy Could you take a look at these?

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Dec 28, 2018

I've been working on this.. Second issue is almost fixed. WIP here: https://github.com/bolt/four/compare/working-on-select-for-taxonomies

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2019

Fixed in #227

@bobdenotter bobdenotter closed this Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.