Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend application code cleanup #280

Closed
marcingajda opened this issue Jan 21, 2019 · 4 comments
Closed

Frontend application code cleanup #280

marcingajda opened this issue Jan 21, 2019 · 4 comments

Comments

@marcingajda
Copy link
Collaborator

@marcingajda marcingajda commented Jan 21, 2019

Goal of this issue is to improve the frontend application code base in both JavaScript and CSS files. This issue includes:

  • Review Eslint and prettier configurations to match widely used standards.
  • Add Stylelint for checking SCSS files
  • Fix linting violations
  • Do some code cleanups like removing unnecessary comment and files
  • Improve directories structure
@bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Jan 21, 2019

👍

Loading

@bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Jan 24, 2019

@marcingajda Maybe also look at #129 ? There's not much activity from the author, but maybe there's some bits and pieces you can use?

Loading

@marcingajda
Copy link
Collaborator Author

@marcingajda marcingajda commented Jan 28, 2019

@bobdenotter Yes, as I responded in that issue earlier I will grab the travis configuration. Sorry that it's taking me so much time, I wanted to finish it this weekend but I get sick 🤒Anyway all parts are done except the travis configuration and I have a problem with stylelint which doesn't want to autofix violations. Probably I will finish it before the end of this week.

Loading

@JarJak
Copy link
Member

@JarJak JarJak commented Feb 4, 2019

Closed by #307

Loading

@JarJak JarJak closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants