Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend application code cleanup #280

Closed
marcingajda opened this issue Jan 21, 2019 · 4 comments
Closed

Frontend application code cleanup #280

marcingajda opened this issue Jan 21, 2019 · 4 comments
Assignees
Labels
topic: DX Improving code quality, tests coverage, making codebase more intuitive topic: Vue

Comments

@marcingajda
Copy link
Collaborator

Goal of this issue is to improve the frontend application code base in both JavaScript and CSS files. This issue includes:

  • Review Eslint and prettier configurations to match widely used standards.
  • Add Stylelint for checking SCSS files
  • Fix linting violations
  • Do some code cleanups like removing unnecessary comment and files
  • Improve directories structure
@bobdenotter
Copy link
Member

👍

@bobdenotter bobdenotter added topic: Vue topic: DX Improving code quality, tests coverage, making codebase more intuitive labels Jan 21, 2019
@JarJak JarJak added this to the Bolt 4 alpha 2 milestone Jan 21, 2019
@bobdenotter
Copy link
Member

@marcingajda Maybe also look at #129 ? There's not much activity from the author, but maybe there's some bits and pieces you can use?

@marcingajda
Copy link
Collaborator Author

@bobdenotter Yes, as I responded in that issue earlier I will grab the travis configuration. Sorry that it's taking me so much time, I wanted to finish it this weekend but I get sick 🤒Anyway all parts are done except the travis configuration and I have a problem with stylelint which doesn't want to autofix violations. Probably I will finish it before the end of this week.

@JarJak
Copy link
Member

JarJak commented Feb 4, 2019

Closed by #307

@JarJak JarJak closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Improving code quality, tests coverage, making codebase more intuitive topic: Vue
Projects
None yet
Development

No branches or pull requests

3 participants