Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for 'config parsers' #379

Closed
bobdenotter opened this issue Apr 3, 2019 · 0 comments · Fixed by #414
Closed

Improve tests for 'config parsers' #379

bobdenotter opened this issue Apr 3, 2019 · 0 comments · Fixed by #414
Labels
topic: DX Improving code quality, tests coverage, making codebase more intuitive
Milestone
Bolt 4 beta 1

Comments

@bobdenotter
Copy link
Member

Taken from conversations in different places:

How does it break? throws an exception? can you test it? #376 (comment)

add file name / path as constructor parameter #376 (comment)

It'll require some changes in all 5 files src/Configuration/Parser, so it needs to be a separate PR. #376 is getting too big.
@bobdenotter bobdenotter added the topic: DX Improving code quality, tests coverage, making codebase more intuitive label Apr 3, 2019
@bobdenotter bobdenotter mentioned this issue Apr 3, 2019
Merged
@JarJak JarJak added this to the Bolt 4 beta 1 milestone Apr 3, 2019
@JarJak JarJak mentioned this issue Apr 5, 2019
Closed
@bobdenotter bobdenotter mentioned this issue Apr 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: DX Improving code quality, tests coverage, making codebase more intuitive
Projects
None yet
Milestone
Bolt 4 beta 1
Development

Successfully merging a pull request may close this issue.

Tests for config parsers bolt/core
2 participants
@bobdenotter @JarJak