Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'setcontent' #41

Closed
bobdenotter opened this issue Oct 23, 2018 · 4 comments
Closed

Make 'setcontent' #41

bobdenotter opened this issue Oct 23, 2018 · 4 comments
Assignees
Labels
needs splitting Issue is too big: Needs to be split up into several smaller issues topic: Frontend topic: Twig

Comments

@bobdenotter
Copy link
Member

No description provided.

@bobdenotter bobdenotter added topic: Twig topic: Frontend needs splitting Issue is too big: Needs to be split up into several smaller issues labels Oct 23, 2018
@JarJak
Copy link
Member

JarJak commented Nov 18, 2018

I hope it's implementation will be less magical than in v3 ;)

@bobdenotter
Copy link
Member Author

@JarJak See #116

It's being worked on by @xiaohutai.. It's definitely based on our Bolt 3 code, but converted to use ORM. I assume by "magic" you mostly mean the hydration, right? That should be handled by ORM now, and it seems much snappier than before.

@JarJak
Copy link
Member

JarJak commented Nov 19, 2018

With "magical" I mean using user_func_*, side effects, implicit changing object state etc.

@bobdenotter
Copy link
Member Author

Closed by #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs splitting Issue is too big: Needs to be split up into several smaller issues topic: Frontend topic: Twig
Projects
None yet
Development

No branches or pull requests

4 participants