Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ Make all required frontend controllers #42

Closed
bobdenotter opened this issue Oct 23, 2018 · 7 comments

Comments

@bobdenotter
Copy link
Member

commented Oct 23, 2018

The following frontend routes need to be implemented:

Frontend

  • homepage | GET | /
  • search | ANY | /search
  • preview | POST | /preview/{contenttypeslug}
  • contentlink | GET | /{contenttypeslug}/{slug}
  • taxonomylink | GET | /{taxonomytype}/{slug}
  • contentlisting | GET | /{contenttypeslug}

@bobdenotter bobdenotter changed the title Make all required frontend controllers ⭐️ Make all required frontend controllers Oct 26, 2018

@bobdenotter bobdenotter added Epic and removed Epic labels Nov 17, 2018

@JarJak

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

actually GET instead of ANY

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2018

That was converted from app/nut debug:router in bolt 3. Will update to GET. 👍

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2018

(Except for "search" ;-) )

@JarJak

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Why not search? it is also a GET request

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2018

@JarJak

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

Search form should not use POST. Speaking RESTful, POST creates new entity, GET fetches data. So, search form should use GET.

@JarJak JarJak added this to the Bolt 4 beta 1 milestone Jan 9, 2019

@JarJak JarJak added the Epic label Feb 4, 2019

@JarJak JarJak assigned JarJak and bobdenotter and unassigned JarJak Feb 4, 2019

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

Closing this for now.. The basics are in, we'll add more routes if something specific needs it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.