Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⭐️ Make all required frontend controllers #42

Closed
6 tasks
bobdenotter opened this issue Oct 23, 2018 · 7 comments
Closed
6 tasks

⭐️ Make all required frontend controllers #42

bobdenotter opened this issue Oct 23, 2018 · 7 comments
Assignees
@bobdenotter
Labels
Epic needs splitting Issue is too big: Needs to be split up into several smaller issues topic: Controllers Symfony Controllers topic: Frontend
Milestone
Bolt 4 beta 1

Comments

@bobdenotter
Copy link
Member

bobdenotter commented Oct 23, 2018 •
edited by xiaohutai
Loading

The following frontend routes need to be implemented:

Frontend

  • homepage | GET | /
  • search | ANY | /search
  • preview | POST | /preview/{contenttypeslug}
  • contentlink | GET | /{contenttypeslug}/{slug}
  • taxonomylink | GET | /{taxonomytype}/{slug}
  • contentlisting | GET | /{contenttypeslug}
@bobdenotter bobdenotter added topic: Frontend topic: Controllers Symfony Controllers needs splitting Issue is too big: Needs to be split up into several smaller issues labels Oct 23, 2018
@bobdenotter bobdenotter changed the title Make all required frontend controllers ⭐️ Make all required frontend controllers Oct 26, 2018
@bobdenotter bobdenotter added Epic and removed Epic labels Nov 17, 2018
@JarJak
Copy link
Member

JarJak commented Nov 21, 2018

actually GET instead of ANY

@bobdenotter
Copy link
Member Author

That was converted from app/nut debug:router in bolt 3. Will update to GET. 👍

@bobdenotter
Copy link
Member Author

(Except for "search" ;-) )

@JarJak
Copy link
Member

JarJak commented Nov 22, 2018

Why not search? it is also a GET request

@bobdenotter
Copy link
Member Author

bobdenotter commented Nov 22, 2018 via email •
edited
Loading

@JarJak
Copy link
Member

JarJak commented Nov 22, 2018 •
edited
Loading

Search form should not use POST. Speaking RESTful, POST creates new entity, GET fetches data. So, search form should use GET.

@JarJak JarJak added this to the Bolt 4 beta 1 milestone Jan 9, 2019
@JarJak JarJak mentioned this issue Feb 1, 2019
Closed
@JarJak JarJak added the Epic label Feb 4, 2019
@JarJak JarJak assigned JarJak and bobdenotter and unassigned JarJak Feb 4, 2019
@bobdenotter
Copy link
Member Author

Closing this for now.. The basics are in, we'll add more routes if something specific needs it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobdenotter bobdenotter

Labels
Epic needs splitting Issue is too big: Needs to be split up into several smaller issues topic: Controllers Symfony Controllers topic: Frontend
Projects
None yet
Milestone
Bolt 4 beta 1
Development

No branches or pull requests
2 participants
@bobdenotter @JarJak