Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PagerFanta, in favor of Doctrine Paginator #444

Open
bobdenotter opened this issue Jun 5, 2019 · 4 comments

Comments

@bobdenotter
Copy link
Member

commented Jun 5, 2019

We're currently using PagerFanta, but the current developers are looking for new maintainers. whiteoctober/Pagerfanta#278

We're already using Doctrine, so this might be a good moment to start using Doctrine's Paginator instead. Two less Composer requirements!

See also: symfony/demo#991

@bobdenotter bobdenotter added this to the Bolt 4 beta 1 milestone Jun 5, 2019

@stof

This comment has been minimized.

Copy link

commented Jun 7, 2019

Note that you are already using Doctrine's Paginator, as Pagerfanta uses it for the low-level pagination.
What the Symfony demo did is replacing Pagerfanta with its own custom code, not replacing it with Doctrine's Paginator.

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

@stof Yes, that's correct! Thanks for the clarification. :-)

@harikt

This comment has been minimized.

Copy link

commented Aug 7, 2019

I would like to pick this issue if this is still relevant when I get some time. Do we need to move something similar to how symfony/demo did ?

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@harikt Yes, exactly..

We'd only need to think about if it impacts convenience for the user.. Right now pagerfanta works both in the frontend as well as in the backend. If we replace it, we can perhaps make a nice snippet for the frontend theme's, so that it'll be a smooth replacement for them. :-)

My colleague @nestordedios already did some work on this, in this branch, but it's not quite finished: https://github.com/bolt/core/tree/feature/doctrine-paginator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.