Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On a page with "widecontent" aside overlaps usable space #510

Closed
bobdenotter opened this issue Jul 8, 2019 · 2 comments

Comments

@bobdenotter
Copy link
Member

commented Jul 8, 2019

See screenshot:

Screenshot 2019-07-08 at 21 28 41

@bobdenotter bobdenotter added this to the Bolt 4 beta 1 milestone Jul 8, 2019

@sbonardt

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

I can fix this but I need some more info on the approach of the content. Currently the aside is written out although there is no content in it. I'm planning on running a check on the aside block if it has content set in the subtemplate. This way we can still define the HTML for the aside in the main template and not give others 'control' over the structure, which would happen if we move the HTML for the aside to the sub templates. I'll rework the styling for this as well

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Fixed in #521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.