Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make login accept (slugified) username, as well as email. #514

Closed
bobdenotter opened this issue Jul 9, 2019 · 1 comment
Closed

Make login accept (slugified) username, as well as email. #514

bobdenotter opened this issue Jul 9, 2019 · 1 comment

Comments

@bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Jul 9, 2019

Because:

  • It's more convenient for users
  • Mobile devices make it hard to do case-correct input in input fields, inputting admin as Admin, making it a hassle for users
@bobdenotter bobdenotter added this to the Bolt 4 beta 3 milestone Jul 9, 2019
fatguytyson added a commit to fatguytyson/core that referenced this issue Sep 17, 2019
Changed the repository method to accept the credential(string) and has
the storage engine compare the lowercase values. At least this is
consistent to the strings compared so it should be a consistent
experience
bobdenotter added a commit that referenced this issue Sep 18, 2019
@bobdenotter
Copy link
Member Author

@bobdenotter bobdenotter commented Sep 28, 2019

Fixed in #633 by @fatguytyson

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant