Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of vibrant cdn #805

Closed
UtechtDustin opened this issue Dec 16, 2019 · 4 comments
Closed

Get rid of vibrant cdn #805

UtechtDustin opened this issue Dec 16, 2019 · 4 comments
Assignees

Comments

@UtechtDustin
Copy link
Contributor

@UtechtDustin UtechtDustin commented Dec 16, 2019

Get rid of the vibrant cdn: https://github.com/bolt/core/blob/master/templates/media/edit.html.twig#L175
https://yarnpkg.com/en/package/node-vibrant

I would submit a PR, but im new to the javascript/webpack stuff, so i dont know how to solve it on a good way. I guess require would not within the twig, because webpack will not "bundle" it then (or?).

@bobdenotter bobdenotter added this to the Bolt 4 release candidate milestone Dec 17, 2019
@bobdenotter

This comment has been minimized.

Copy link
Member

@bobdenotter bobdenotter commented Dec 17, 2019

Yeah, let's get rid of that! :-)

Ideally, when Bolt 4 is stable, it should require no assets that aren't local.

What needs to be done (in very broad strokes) is that a new 'vibrant.js' should be made in https://github.com/bolt/core/tree/master/assets/js , that would require the node-vibrant, and have that other code that's inlined in there. Then, that can be used with an {{ asset() }} tag in the twig.
Kinda like how zxcvbn.js is now used for the password strength thingy, only on the pages where it's needed.

@UtechtDustin

This comment has been minimized.

Copy link
Contributor Author

@UtechtDustin UtechtDustin commented Dec 17, 2019

Oh okay!
I already thought that this is the way to go, but i was uncertain if there is a better way for that.
Could you assign me the issue ? (I will check it this evening)

@bobdenotter

This comment has been minimized.

Copy link
Member

@bobdenotter bobdenotter commented Dec 17, 2019

There you go! :-)

@I-Valchev

This comment has been minimized.

Copy link
Collaborator

@I-Valchev I-Valchev commented Dec 18, 2019

Fixed in #808

@I-Valchev I-Valchev closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.