Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add record.link() and record.canonical() functions #937

Closed
I-Valchev opened this issue Jan 28, 2020 · 2 comments
Closed

Add record.link() and record.canonical() functions #937

I-Valchev opened this issue Jan 28, 2020 · 2 comments
Assignees
@bobdenotter
Labels
📙 tag: documentation wontfix
Milestone
Bolt 4.0.0 stable

Comments

@I-Valchev
Copy link
Member

I-Valchev commented Jan 28, 2020

No description provided.

@I-Valchev I-Valchev added this to the Bolt 4.0.0 stable milestone Jan 28, 2020
@bobdenotter
Copy link
Member

bobdenotter commented Jan 28, 2020

We shouldn't do this. The old link in v3 was confusing. When a contenttype had a field named link, the results of {{ record.link }} were confusing. In v4, this is made explicit by using the |link "magic attribute".

{{ record|link() }} -> absolute link
{{ record|link(true) }} -> canonical URL

I'm not closing this yet, until we're sure it's documented as such. :-)

@bobdenotter bobdenotter self-assigned this Feb 6, 2020
This was referenced Feb 7, 2020
Closed
Merged
@bobdenotter
Copy link
Member

bobdenotter commented Feb 7, 2020

Fixed by bolt/docs#1002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobdenotter bobdenotter

Labels
📙 tag: documentation wontfix
Projects
None yet
Milestone
Bolt 4.0.0 stable
Development

Successfully merging a pull request may close this issue.

Document "Extras" bolt/docs
2 participants
@bobdenotter @I-Valchev