Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API shows published and viewless: false content only #1305

Merged
merged 2 commits into from Apr 16, 2020

Conversation

I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented Apr 16, 2020

API work is planned ahead for v4.3, however this seems important to fix now.

Fixes #1295 and #1296

@I-Valchev I-Valchev changed the title API shows published content only [WIP] API shows published content only Apr 16, 2020
@I-Valchev I-Valchev changed the title [WIP] API shows published content only API shows published and viewless: false content only Apr 16, 2020
Copy link
Member

@bobdenotter bobdenotter left a comment

:shipit:

@bobdenotter bobdenotter merged commit 3556523 into master Apr 16, 2020
1 check passed
@bobdenotter bobdenotter deleted the feature/filter-unpublished-content-api branch Apr 16, 2020
@bobdenotter bobdenotter added this to the Bolt 4.0.0 stable milestone Apr 16, 2020
@technicallyerik
Copy link
Contributor

technicallyerik commented Apr 17, 2020

Y'all are fast!

I tested these changes and the Unpublished filter looks good.

I wanted to get your thoughts on applying $this->excludeViewlessContent($queryBuilder); to applyToCollection as well, to make it consistent with how viewless works on the front-end.

@I-Valchev
Copy link
Member Author

I-Valchev commented Apr 17, 2020

Oops - this is what I intended originally. Nice spot, thanks it will get fixed :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants