From ec0023107cddf741488858b1a87224a1683da88f Mon Sep 17 00:00:00 2001 From: Ivo Valchev Date: Tue, 5 Jan 2021 13:50:07 +0100 Subject: [PATCH 1/3] Fix behat tests --- .github/workflows/behavioural_tests.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/behavioural_tests.yaml b/.github/workflows/behavioural_tests.yaml index 240740428..866de1833 100644 --- a/.github/workflows/behavioural_tests.yaml +++ b/.github/workflows/behavioural_tests.yaml @@ -15,10 +15,10 @@ jobs: steps: - uses: actions/checkout@v2 - uses: shivammathur/setup-php@v1 - with: - # test the lowest version, to make sure checks pass on it - php-version: ${{ matrix.php-version }} - coverage: none + with: + # test the lowest version, to make sure checks pass on it + php-version: ${{ matrix.php-version }} + coverage: none - name: Install dependencies run: | sudo composer self-update -q From a115c683895a910cb6a6acfeada8f86a8635f989 Mon Sep 17 00:00:00 2001 From: Ivo Valchev Date: Tue, 5 Jan 2021 17:03:44 +0100 Subject: [PATCH 2/3] Update behavioural_tests.yaml --- .github/workflows/behavioural_tests.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/behavioural_tests.yaml b/.github/workflows/behavioural_tests.yaml index 866de1833..ae8b90330 100644 --- a/.github/workflows/behavioural_tests.yaml +++ b/.github/workflows/behavioural_tests.yaml @@ -55,6 +55,7 @@ jobs: fail-fast: false matrix: node-version: ['12.5'] + php-version: ['7.2'] steps: - uses: actions/checkout@v2 - uses: shivammathur/setup-php@v1 From acff623419769c9d5a137be092b46d3695f24b8b Mon Sep 17 00:00:00 2001 From: Ivo Valchev Date: Wed, 6 Jan 2021 10:18:36 +0100 Subject: [PATCH 3/3] Fix embed size --- tests/e2e/edit_record_1.feature | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/e2e/edit_record_1.feature b/tests/e2e/edit_record_1.feature index 9623744dd..60d6aefff 100644 --- a/tests/e2e/edit_record_1.feature +++ b/tests/e2e/edit_record_1.feature @@ -52,8 +52,8 @@ Feature: Edit record And I wait for "fields[embed][title]" field value to change Then the "fields[embed][title]" field should contain "Silversun Pickups - Nightlight (Official Video)" And the "fields[embed][authorname]" field should contain "Silversun Pickups" - And the "fields[embed][width]" field should contain "480" - And the "fields[embed][height]" field should contain "270" + And the "fields[embed][width]" field should contain "200" + And the "fields[embed][height]" field should contain "113" When I click ".editor__embed .remove" # Add wait to make sure JS clears the fields before assert occurs