Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Preview" and "View saved" options to editing content #279

Closed
wants to merge 6 commits into from

Conversation

@bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Jan 20, 2019

Fixes #184


return $this->renderTemplate($templates, $context);
}

private function contentFromPost(?Content $content, Request $request): Content
Copy link
Member

@JarJak JarJak Jan 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to separate service and unit test it

Loading

@JarJak
Copy link
Member

@JarJak JarJak commented Jan 21, 2019

tests are missing

Loading

@bobdenotter bobdenotter force-pushed the preview-and-view-saved branch 2 times, most recently from d3fd549 to ec30c8a Jan 21, 2019
@bobdenotter bobdenotter force-pushed the preview-and-view-saved branch from ec30c8a to f97f74f Jan 21, 2019
@@ -141,6 +141,16 @@ public function __construct()
$this->taxonomies = new ArrayCollection();
}

public static function factory(string $contentType, User $user, LaravelCollection $contenttypes): self
Copy link
Member

@JarJak JarJak Jan 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$contenttypes -> $contentTypesConfig

Loading

@JarJak JarJak added this to the Bolt 4 alpha 2 milestone Jan 24, 2019
@bobdenotter
Copy link
Member Author

@bobdenotter bobdenotter commented Jan 24, 2019

Holy mother of Batman, so many merge conflicts when I want to rebase this to master..

Going to close this, and do it over.

Loading

@JarJak
Copy link
Member

@JarJak JarJak commented Jan 24, 2019

@bobdenotter hah, in these situations I prefer merge over rebase :D

Loading

@bobdenotter bobdenotter deleted the preview-and-view-saved branch Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants