Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][WIP] Introduce Symfony Forms #332

Open
wants to merge 14 commits into
base: master
from

Conversation

@JarJak
Copy link
Member

commented Feb 22, 2019

Let's use Symfony Forms everywhere.

Advantages:

  • CQRS security by default
  • unit testable
  • front-end and back-end validation
  • allows adding custom validation to any field
  • ability to use form themes for fields
  • allow adding more field types (by extensions?)

TODO:

  • frontend / Vue components need to follow up
  • Manual tests: Check if all fields, relations, taxonomies are saved correctly. Test if validation works as expected.
  • E2E tests won't pass until some frontend dev will fix forms in twig.

Closes #331

Jarek Jakubowski
Jarek Jakubowski
@bobdenotter

This comment has been minimized.

Copy link
Member

commented Feb 24, 2019

When the other open stuff is merged in, i'll take a closer lok at this, and see if I can help out with the "frontend" stuff as well. Neat!

@JarJak JarJak changed the base branch from feature/related-content to master Feb 27, 2019

@JarJak

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

Reminder: I have to rebase this PR and resolve conflicts.

Jarek Jakubowski added some commits Mar 21, 2019

Jarek Jakubowski
Jarek Jakubowski
@bobdenotter

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

This is the error i'm getting now, when trying to edit an existing or new record.

Schermafbeelding 2019-03-22 om 14 11 32

Jarek Jakubowski added some commits Mar 25, 2019

@bobdenotter

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Getting a bit further than before now.. Currently getting this error when trying to edit any record:

Schermafbeelding 2019-03-27 om 09 07 54

@bobdenotter

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@JarJak Gentle nudge.. Any progress on this PR? :-)

@JarJak

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

@bobdenotter This error might be related to ConfigParser. Looks like field definition is parsed into an invalid collection class. FieldType and DeepCollection are both collections. Can you debug it?

@bobdenotter

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

This error might be related to ConfigParser. Looks like field definition is parsed into an invalid collection class. FieldType and DeepCollection are both collections. Can you debug it?

My plan for this weekend was to do this refactoring for the configparser (with tests) we discussed earlier. When that's done, I'm fairly certain I can sort this one out to.
(First we need to merge #376 though.. *hint* *hint*)

@bobdenotter

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

This error might be related to ConfigParser. Looks like field definition is parsed into an invalid collection class. FieldType and DeepCollection are both collections. Can you debug it?

Thinking about this some more.. I quickly edited the typehints to be a general Collection, so both types would pass.

Next error is this one:

Screenshot 2019-04-05 at 07 16 21

I will keep working on cleaning up the configparsers in the meantime.

@bobdenotter bobdenotter added this to the Bolt 4 beta 2 milestone Apr 10, 2019

Jarek Jakubowski added some commits Apr 11, 2019

@JarJak JarJak force-pushed the feature/symfony-forms branch from df87cfb to 7105f58 Apr 11, 2019

Jarek Jakubowski added some commits Apr 12, 2019

Jarek Jakubowski
Jarek Jakubowski
Jarek Jakubowski
Jarek Jakubowski
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.