Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search work in Frontend #364

Merged
merged 14 commits into from Mar 29, 2019

Conversation

@bobdenotter
Copy link
Member

commented Mar 23, 2019

Fixes #306

todo:

  • Update search template
  • Make search controller work
  • Implement naive search
  • Add tests

@bobdenotter bobdenotter changed the title [WIP] Make search work in Frontend Make search work in Frontend Mar 24, 2019

@bobdenotter bobdenotter requested a review from JarJak Mar 24, 2019

@bobdenotter bobdenotter force-pushed the frontend-search branch 2 times, most recently from f783d0b to 9956117 Mar 24, 2019

Makefile Outdated Show resolved Hide resolved
public/theme/skeleton/search.twig Show resolved Hide resolved
public/theme/skeleton/search.twig Show resolved Hide resolved
public/theme/skeleton/search.twig Show resolved Hide resolved
src/Repository/ContentRepository.php Outdated Show resolved Hide resolved
src/Twig/RecordExtension.php Outdated Show resolved Hide resolved
src/Twig/RecordExtension.php Outdated Show resolved Hide resolved
src/Twig/RecordExtension.php Outdated Show resolved Hide resolved
tests/e2e/pages/homepage.js Outdated Show resolved Hide resolved
src/Controller/Frontend/SearchController.php Outdated Show resolved Hide resolved
src/Controller/Frontend/SearchController.php Outdated Show resolved Hide resolved
src/Repository/ContentRepository.php Outdated Show resolved Hide resolved
src/Controller/Frontend/SearchController.php Outdated Show resolved Hide resolved
src/Controller/Frontend/SearchController.php Outdated Show resolved Hide resolved

@bobdenotter bobdenotter force-pushed the frontend-search branch from 85fba83 to 44430b7 Mar 29, 2019

@bobdenotter bobdenotter force-pushed the frontend-search branch from 44430b7 to 1141deb Mar 29, 2019

@bobdenotter bobdenotter requested a review from JarJak Mar 29, 2019

Makefile Show resolved Hide resolved
public/theme/skeleton/search.twig Outdated Show resolved Hide resolved

@bobdenotter bobdenotter requested a review from JarJak Mar 29, 2019

@JarJak

JarJak approved these changes Mar 29, 2019

@bobdenotter

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

Thanks!

@bobdenotter bobdenotter merged commit 85ca92d into master Mar 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bobdenotter bobdenotter deleted the frontend-search branch Mar 29, 2019

@bobdenotter bobdenotter added this to the Bolt 4 beta 1 milestone Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.