Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search work in Frontend #364

Merged
merged 14 commits into from Mar 29, 2019
Merged

Make search work in Frontend #364

merged 14 commits into from Mar 29, 2019

Conversation

bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Mar 23, 2019 •
edited

Fixes #306

todo:

  • Update search template
  • Make search controller work
  • Implement naive search
  • Add tests

@bobdenotter bobdenotter changed the title [WIP] Make search work in Frontend Make search work in Frontend Mar 24, 2019
@bobdenotter bobdenotter requested a review from JarJak March 24, 2019 07:16
@bobdenotter bobdenotter force-pushed the frontend-search branch 2 times, most recently from f783d0b to 9956117 Compare March 24, 2019 13:08
JarJak
JarJak requested changes Mar 25, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
public/theme/skeleton/search.twig Show resolved Hide resolved
public/theme/skeleton/search.twig Show resolved Hide resolved
public/theme/skeleton/search.twig Show resolved Hide resolved
src/Repository/ContentRepository.php Outdated Show resolved Hide resolved
src/Twig/RecordExtension.php Outdated Show resolved Hide resolved
src/Twig/RecordExtension.php Outdated Show resolved Hide resolved
src/Twig/RecordExtension.php Outdated Show resolved Hide resolved
tests/e2e/features/display_search.feature Show resolved Hide resolved
tests/e2e/pages/homepage.js Outdated Show resolved Hide resolved
@bobdenotter bobdenotter mentioned this pull request Mar 25, 2019
Closed
JarJak
JarJak requested changes Mar 28, 2019
View reviewed changes
src/Repository/ContentRepository.php Outdated Show resolved Hide resolved
src/Controller/Frontend/SearchController.php Outdated Show resolved Hide resolved
src/Controller/Frontend/SearchController.php Outdated Show resolved Hide resolved
@bobdenotter bobdenotter requested a review from JarJak March 29, 2019 09:26
JarJak
JarJak requested changes Mar 29, 2019
View reviewed changes
Makefile Show resolved Hide resolved
public/theme/skeleton/search.twig Outdated Show resolved Hide resolved
src/Controller/Frontend/SearchController.php Show resolved Hide resolved
@bobdenotter bobdenotter requested a review from JarJak March 29, 2019 10:15
@bobdenotter
Copy link
Member Author

Thanks!

@bobdenotter bobdenotter merged commit 85ca92d into master Mar 29, 2019
@bobdenotter bobdenotter deleted the frontend-search branch March 29, 2019 15:27
@bobdenotter bobdenotter mentioned this pull request Mar 29, 2019
Merged
@bobdenotter bobdenotter added this to the Bolt 4 beta 1 milestone Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stryxx stryxx stryxx left review comments

@JarJak JarJak JarJak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bolt 4 beta 1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobdenotter @JarJak @stryxx