Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/extract menus, and cache them properly #389

Merged
merged 10 commits into from Apr 13, 2019

Conversation

bobdenotter
Copy link
Member

Fixes #380. Fixes #388

src/Menu/BackendMenuBuilder.php Outdated Show resolved Hide resolved
src/Menu/CachedBackendMenuBuilder.php Outdated Show resolved Hide resolved
src/Menu/CachedBackendMenuBuilder.php Outdated Show resolved Hide resolved
src/Menu/CachedFrontendMenuBuilder.php Outdated Show resolved Hide resolved
src/Twig/BackendMenuExtension.php Outdated Show resolved Hide resolved
src/Twig/BackendMenuExtension.php Outdated Show resolved Hide resolved
src/Twig/FrontendMenuExtension.php Outdated Show resolved Hide resolved
src/Menu/CachedFrontendMenuBuilder.php Outdated Show resolved Hide resolved
src/Menu/CachedFrontendMenuBuilder.php Outdated Show resolved Hide resolved
src/Menu/CachedFrontendMenuBuilder.php Outdated Show resolved Hide resolved
src/Menu/CachedBackendMenuBuilder.php Outdated Show resolved Hide resolved
src/Menu/CachedBackendMenuBuilder.php Outdated Show resolved Hide resolved
src/Menu/CachedBackendMenuBuilder.php Outdated Show resolved Hide resolved
src/Menu/BackendMenuBuilder.php Outdated Show resolved Hide resolved
@bobdenotter
Copy link
Member Author

Made a few additional changes. Let's get this in. If there's further refactoring that can be done, we will do it in additional PR's. This one is done. :-)

@bobdenotter bobdenotter added this to the Bolt 4 beta 1 milestone Apr 10, 2019
src/Twig/FrontendMenuExtension.php Outdated Show resolved Hide resolved
src/Twig/FrontendMenuExtension.php Outdated Show resolved Hide resolved
@JarJak
Copy link
Member

JarJak commented Apr 11, 2019

Let's get this in

No. Not without tests. Please learn to write them.

Test for BackendMenuBuilder is missing.

Jarek Jakubowski and others added 2 commits April 12, 2019 20:49
@bobdenotter bobdenotter merged commit 66d816e into master Apr 13, 2019
@bobdenotter bobdenotter deleted the refactor/extract-menus branch April 13, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract creating menus from RecordExtension Use CacheWrapper pattern for Sidebarmenu construction.
2 participants