Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register composer installed extensions, remove Weather Widget #559

Merged
merged 10 commits into from Aug 3, 2019

Conversation

@bobdenotter
Copy link
Member

commented Aug 3, 2019

See #134, #492

@bobdenotter bobdenotter merged commit 185f522 into master Aug 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bobdenotter bobdenotter deleted the register-composer-installed-extensions branch Aug 3, 2019

@bobdenotter bobdenotter added this to the Bolt 4 beta 2 milestone Aug 3, 2019

// because PHPStan is being a smart-ass, and takes the state of the
// generated `Types` class into account. And that's exactly the point.
try {
$packages = Types::boltExtension();

This comment has been minimized.

Copy link
@drupol

drupol Aug 4, 2019

I think you might remove the try/catch if you use:

<?php

iterator_to_array(Types::get('bolt-extension'));

This comment has been minimized.

Copy link
@bobdenotter

bobdenotter Aug 5, 2019

Author Member

Ah, yes! much nicer. I've fixed it straight away! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.