Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/collections support all fields #787

Merged
merged 9 commits into from Dec 12, 2019

Conversation

@I-Valchev
Copy link
Collaborator

I-Valchev commented Dec 12, 2019

Fixes #767
All fields are supported in collections.
@bobdenotter are you happy with the way they collections are displayed? Do you think the boundaries of a collection item are clear enough?
For reference:
Screenshot 2019-12-12 at 09 56 13

@UtechtDustin

This comment has been minimized.

Copy link
Contributor

UtechtDustin commented Dec 12, 2019

The buttons to move down/up and to delete are very big in my opinion, it would make more sense to use only Icons with the title attribute and move them to the top right of each field.
Also the Buttons of the departments field has no margin-top.

Copy link
Member

bobdenotter left a comment

@I-Valchev Let's merge this one in, as-is. That said, I agree the position and look/feel of the buttons can do with a bit of refinement.

Maybe @anketwokings or @sbonardt would like to take a look at that, together with you?

@bobdenotter bobdenotter merged commit 91a9580 into master Dec 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bobdenotter bobdenotter deleted the feature/collections-support-all-fields branch Dec 12, 2019
@bobdenotter bobdenotter added this to the Bolt 4 release candidate milestone Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.