Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement {{ record|current }} Twig filter #957

Merged
merged 3 commits into from Feb 1, 2020

Conversation

bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Jan 28, 2020

Fixes #949

Copy link
Member

@I-Valchev I-Valchev left a comment

To make sure: did you check how this works with localization on?
I'm thinking how the fact that slugs may differ across locales can change this.

For example:
EN locale: test-page
NL locale: test-page-nl
JP locale: test-page (default, when it's not set)

@bobdenotter bobdenotter changed the title Implement {{ record|current }} Twig filter [WIP] Implement {{ record|current }} Twig filter Jan 29, 2020
@bobdenotter
Copy link
Member Author

bobdenotter commented Jan 29, 2020

Marked [WIP], cause it needs some more work for l10n support

@bobdenotter bobdenotter force-pushed the Implement-`{{-record-current-}}`-Twig-filter branch from 20049fe to 117fe06 Compare Feb 1, 2020
@bobdenotter
Copy link
Member Author

bobdenotter commented Feb 1, 2020

Now also works well with localization!

@bobdenotter bobdenotter added this to the Bolt 4 release candidate milestone Feb 1, 2020
@bobdenotter bobdenotter changed the title [WIP] Implement {{ record|current }} Twig filter Implement {{ record|current }} Twig filter Feb 1, 2020
@bobdenotter bobdenotter merged commit 6c606e5 into master Feb 1, 2020
1 check passed
@bobdenotter bobdenotter deleted the Implement-`{{-record-current-}}`-Twig-filter branch Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants