New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base 2018 #14

Merged
merged 9 commits into from Mar 14, 2018

Conversation

Projects
None yet
6 participants
@bobdenotter
Member

bobdenotter commented Mar 13, 2018

Let's go to beta!

Screenshots:

screenshot-2018-3-13 quodsi ipsam honestatem undique pertectam atque absolutam a sample site


screenshot-2018-3-13 cur id non ita fit a sample site


screenshot-2018-3-13 quam nemo umquam voluptatem appellavit appellat a sample site


screenshot-2018-3-13 omnes enim iucundum motum quo sensus hilaretur a sample site


screenshot-2018-3-13 a sample site the amazing payoff goes here 1


screenshot-2018-3-13 a sample site the amazing payoff goes here

</div>
</footer>
<script src="{{ asset('js/jquery.js', 'theme') }}"></script>

This comment has been minimized.

@xiaohutai

xiaohutai Mar 13, 2018

Member

[Performance/Optimization] Concat and minify these four scripts?

This comment has been minimized.

@bobdenotter

bobdenotter Mar 13, 2018

Member

Maybe. I kinda like that people can remove stuff if they don't like it. That said: magnific and brightness do need to go into app.js, and I might want to add Prism, for out-of-the-box pretty code snippets.

This comment has been minimized.

@GawainLynch

GawainLynch Mar 13, 2018

Contributor

We could do something sensible, like realise that jQuery shouldn't be used post-2015, no?

//assets: [
// 'src/assets/**/*',
// '!src/assets/{img,js,scss}/**/*'
//],

This comment has been minimized.

@GawainLynch

GawainLynch Mar 13, 2018

Contributor

Remove please

</div>
{# <div class="buttons has-addons is-right">
<a class="button is-primary" href="{{ path('contentlisting', {'contenttypeslug': 'pages'}) }}">Read more<span class="is-hidden"> Pages</span></a>
</div> #}

This comment has been minimized.

@GawainLynch

GawainLynch Mar 13, 2018

Contributor

Remove please

@zomars

This comment has been minimized.

Contributor

zomars commented Mar 13, 2018

+1 for Bulima <3

@GawainLynch

This comment has been minimized.

Contributor

GawainLynch commented Mar 14, 2018

Removed Jquery and Magnific. Added Prism and Baguettebox.

How awesome was it to wake to this today! ❤️

@GawainLynch GawainLynch changed the title from Feature/base 2018 to Base 2018 Mar 14, 2018

@GawainLynch GawainLynch merged commit 6d15fc3 into master Mar 14, 2018

@GawainLynch GawainLynch deleted the feature/base-2018 branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment