[3.3] "not found" image throws an exception

[bobdenotter]

Screenshot:

Happens on Bolt 3.3.0 beta 5 on a "git clone" install. I have doublechecked app/view/img/default_notfound.png is present and readable.

[bobdenotter]

Full trace:

DefaultImageNotFoundException in ThumbnailsServiceProvider.php line 126:
Unable to locate notfound image for thumbnails. Looked for: "view/img/default_notfound.png". Please update "thumbnails/notfound_image" in config.yml.

in ThumbnailsServiceProvider.php line 126
at ThumbnailsServiceProvider->findDefaultImage(object(Application), 'notfound') in ThumbnailsServiceProvider.php line 72
at ThumbnailsServiceProvider->Bolt\Provider\{closure}(object(Application)) in Pimple.php line 126
at Pimple::{closure}(object(Application)) in Pimple.php line 83
at Pimple->offsetGet('thumbnails.default_image') in ServiceProvider.php line 48
at ServiceProvider->Bolt\Thumbs\{closure}(object(Application)) in Pimple.php line 126
at Pimple::{closure}(object(Application)) in Pimple.php line 83
at Pimple->offsetGet('thumbnails.finder') in ServiceProvider.php line 28
at ServiceProvider->Bolt\Thumbs\{closure}(object(Application)) in Pimple.php line 126
at Pimple::{closure}(object(Application)) in Pimple.php line 83
at Pimple->offsetGet('thumbnails') in Controller.php line 134
at Controller->serve(object(Application), object(Request), 'foooooooo.jpg', 'resize', '1000', '800') in Controller.php line 81
at Controller->thumbnail(object(Application), object(Request), 'foooooooo.jpg', 'resize', '1000', '800')
at call_user_func_array(array(object(Controller), 'thumbnail'), array(object(Application), object(Request), 'foooooooo.jpg', 'resize', '1000', '800')) in HttpKernel.php line 144
at HttpKernel->handleRaw(object(Request), '1') in HttpKernel.php line 64
at HttpKernel->handle(object(Request), '1', true) in Application.php line 586
at Application->handle(object(Request)) in Application.php line 563
at Application->run(object(Request)) in Application.php line 96
at Application->run() in index.php line 12

1/2
FileNotFoundException in Matcher.php line 77:
File not found at path: view/img/default_notfound.png

in Matcher.php line 77
at Matcher->getFile('view/img/default_notfound.png') in Matcher.php line 95
at Matcher->getImage('view/img/default_notfound.png') in ThumbnailsServiceProvider.php line 124
at ThumbnailsServiceProvider->findDefaultImage(object(Application), 'notfound') in ThumbnailsServiceProvider.php line 72
at ThumbnailsServiceProvider->Bolt\Provider\{closure}(object(Application)) in Pimple.php line 126
at Pimple::{closure}(object(Application)) in Pimple.php line 83
at Pimple->offsetGet('thumbnails.default_image') in ServiceProvider.php line 48
at ServiceProvider->Bolt\Thumbs\{closure}(object(Application)) in Pimple.php line 126
at Pimple::{closure}(object(Application)) in Pimple.php line 83
at Pimple->offsetGet('thumbnails.finder') in ServiceProvider.php line 28
at ServiceProvider->Bolt\Thumbs\{closure}(object(Application)) in Pimple.php line 126
at Pimple::{closure}(object(Application)) in Pimple.php line 83
at Pimple->offsetGet('thumbnails') in Controller.php line 134
at Controller->serve(object(Application), object(Request), 'foooooooo.jpg', 'resize', '1000', '800') in Controller.php line 81
at Controller->thumbnail(object(Application), object(Request), 'foooooooo.jpg', 'resize', '1000', '800')
at call_user_func_array(array(object(Controller), 'thumbnail'), array(object(Application), object(Request), 'foooooooo.jpg', 'resize', '1000', '800')) in HttpKernel.php line 144
at HttpKernel->handleRaw(object(Request), '1') in HttpKernel.php line 64
at HttpKernel->handle(object(Request), '1', true) in Application.php line 586
at Application->handle(object(Request)) in Application.php line 563
at Application->run(object(Request)) in Application.php line 96
at Application->run() in index.php line 12

[CarsonF]

Yeah that's intentional. Change it to bolt_assets://img/default_notfound.png.

[bobdenotter]

That means it'll break between 3.2 and 3.3. :-/

We should keep track of this better, so we can put it in a release notes / upgrade type of thing.

[CarsonF]

We can check for view/ at the beginning of the path and remove it to fix that exception and trigger a deprecation notice instead, if you want.

The exception is new to fix another problem on 3.2. So this was probably hidden until recently.

[bobdenotter]

Nah, seems like that'd be just introducing more deprecated things. It should just be documented somewhere, for people who update and/or bump into it.

[CarsonF]

Yeah it would be, but you're right that it's a BC break.