-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add meson build system #803
Conversation
Lovely! I would say this supersedes the other path PR #773? |
This makes it easier for downstream packagers to customize where howdy installs its files.
Add Meson as a build system for the whole howdy package, which allow better flexibility for the paths configuration. Generate a python module, which contains the paths used by the other modules and the header containing the paths for the PAM module.
Yes, it includes the commit from the other PR and takes it a step further with Meson. |
Should we first merge this PR and progressively create the remaining parts on other PRs, or merge all the changes on this one? Because I'm not sure if you will be able to review if I don't split the changes. |
Add meson for howdy-gtk and a global meson script for both.
Amazing, i've merged beta into your branch and that should hopefully be clean now. Any other PRs that i merge i'll make sure will use your new path factory system. Please check if my merge commit did not fuck anything up, and as i've made you collaborator you should be able to merge it yourself if it's all good! Thanks for all you do for Howdy! |
Thanks, you're welcome! |
I added the latest changes for user model checking and fixed all the remaining problems, it can be now merged! |
Merged 🎉 Thanks again! |
Based on #773, add Meson as a build system for the whole howdy package,
which allows better flexibility for the paths' configuration.
Generate a python module,
which contains the paths used by the other modules,
by using
PurePath
to simplify path concatenation and limit errors,and the header containing the paths for the PAM module.
Closes #836