chore: update preview workflow#39
Open
ghostdevv wants to merge 6 commits into
Open
Conversation
Without this it means that, for example, if I push a change to a PR then shortly push again this workflow will be running twice. This change will cancel the old run before starting the new one, which reduces the overall actions cost and DX as you don't have extra runs
This was referenced May 23, 2026
commit: |
jbolda
approved these changes
May 24, 2026
Comment on lines
+42
to
+44
| run: deno task build:npm ${STEPS_VARS_OUTPUTS_VERSION} | ||
| env: | ||
| STEPS_VARS_OUTPUTS_VERSION: ${{steps.vars.outputs.version}} |
Collaborator
There was a problem hiding this comment.
Out of curiosity, what is the reasoning for this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does some hardening, action updates, and performance improvements to the preview workflow. I split each change up into separate commits to make it easier to review, some of them also have descriptions. I'm fairly confident this won't break.