New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixel offsets #1

Closed
varna9000 opened this Issue Aug 30, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@varna9000

varna9000 commented Aug 30, 2018

Hi, could you please patch the driver to allow screen x and y offset? I got a display which leaves some artefacts because of wrong (possibly ) memory mapping. Thank you.

@boochow

This comment has been minimized.

Show comment
Hide comment
@boochow

boochow Aug 31, 2018

Owner

Hi @varna9000 , if your display had a plastic film with green or blue tab, please try modifying graphicstest.py to replace initr() at line 8 with initg() or initb()

Owner

boochow commented Aug 31, 2018

Hi @varna9000 , if your display had a plastic film with green or blue tab, please try modifying graphicstest.py to replace initr() at line 8 with initg() or initb()

@varna9000

This comment has been minimized.

Show comment
Hide comment
@varna9000

varna9000 Sep 1, 2018

Hi @boochow, I don't remember what the tab colour was. I did replaced the functions on line 8, but with initr() and initg() I get the random pixel lines. With initb() the display is not working at all (except for the backlight). Any ideas why "b" is not working? I suspect my screen is blue tab.

varna9000 commented Sep 1, 2018

Hi @boochow, I don't remember what the tab colour was. I did replaced the functions on line 8, but with initr() and initg() I get the random pixel lines. With initb() the display is not working at all (except for the backlight). Any ideas why "b" is not working? I suspect my screen is blue tab.

@boochow

This comment has been minimized.

Show comment
Hide comment
@boochow

boochow Sep 2, 2018

Owner

You mentioned "some artifacts".
Is it like a set of garbage pixels seen in this picture?
https://blog.boochow.com/wp-content/uploads/arduino08-03.jpg

Owner

boochow commented Sep 2, 2018

You mentioned "some artifacts".
Is it like a set of garbage pixels seen in this picture?
https://blog.boochow.com/wp-content/uploads/arduino08-03.jpg

@varna9000

This comment has been minimized.

Show comment
Hide comment
@varna9000

varna9000 Sep 2, 2018

@boochow yes, this is what I'm getting exactly! Do you know how to make an offset as it seems the whole display area is shifted with 1 or 2 pixels.

varna9000 commented Sep 2, 2018

@boochow yes, this is what I'm getting exactly! Do you know how to make an offset as it seems the whole display area is shifted with 1 or 2 pixels.

@boochow

This comment has been minimized.

Show comment
Hide comment
@boochow

boochow Sep 3, 2018

Owner

@varna9000 basically, adding offset values to parameters of _setwindowpoint() and _setwindowloc() makes it work. I added some lines and initb2() method to add (+2, +1) offset. Please try this new version.
( You need to modify line 8 of graphicstest.py to call initb2() method. )

Owner

boochow commented Sep 3, 2018

@varna9000 basically, adding offset values to parameters of _setwindowpoint() and _setwindowloc() makes it work. I added some lines and initb2() method to add (+2, +1) offset. Please try this new version.
( You need to modify line 8 of graphicstest.py to call initb2() method. )

@varna9000

This comment has been minimized.

Show comment
Hide comment
@varna9000

varna9000 Sep 3, 2018

Works perfectly. Thank you!

varna9000 commented Sep 3, 2018

Works perfectly. Thank you!

@boochow boochow closed this Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment