New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perlcritic errors #42

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@paultcochrane

paultcochrane commented May 27, 2016

These commits fix the most basic perlcritic issues in the dist (at severity level 5). The last commit avoids the expression form of eval in the POD-related tests, however adds a new dependency. If this change isn't desired, please cherry pick as necessary. If you wish for improvements or alterations to the PR as it stands, please let me know and I'll make the necessary changes and resubmit.

paultcochrane added some commits May 27, 2016

Use 3-argument form of open
It is considered best practice to use the 3-argument form of the `open`
function.
Use warnings and strict in all test scripts
Although these pragmas might not be strictly necessary in the files updated
by this commit, they're definitely handy to have around.  Also, the speed
reduction by adding them is very small in comparison to the entire test
suite runtime.
Use Class::Load to check availability of Test::Pod modules
This avoids the expression form of `eval` for achieving the same task; the
expression form of `eval` isn't considered good practice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment