New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix t/23connect.t (PR challenge) #8

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@zhouzhen1

zhouzhen1 commented Feb 20, 2016

I got t/23connect.t failure same as this one: http://www.cpantesters.org/cpan/report/b7d0a086-d278-11e5-a2ee-9fa967b6c32e. And I see #7 seems to be the same issue.

IMHO the issue is that $sock from HTTP::Response client_socket is an Net::HTTP object that has its http_buf already storing the message, so a fresh $read = <$sock>; reads nothing.

I just made minimal change to it, although I think there's another option to change CONNECT to GET.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment