Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statistics-page): add new table to show count of total entities #191

Merged
merged 3 commits into from Jan 15, 2019

Conversation

@akhilesh26
Copy link
Contributor

commented Mar 20, 2018

Add new table with column Entity Type, Total and
Added in last 30 days. In this table shows that total count of
entities in each entity type.

Problem

Solution

Areas of Impact

src/client/components/pages/statistics.js
src/client/controllers/statistics.js
src/server/routes/statistics.js
src/server/helpers/utils.js

After adding, Stats page looks as
statswithentityount

@coveralls

This comment has been minimized.

Copy link

commented Mar 20, 2018

Coverage Status

Coverage decreased (-0.2%) to 56.835% when pulling 538a0e4 on akhilesh26:statistics_addEntityCountTable into 05f08f5 on bookbrainz:master.

@coveralls

This comment has been minimized.

Copy link

commented Mar 20, 2018

Coverage Status

Coverage decreased (-0.2%) to 41.441% when pulling e79108b on akhilesh26:statistics_addEntityCountTable into 7a56657 on bookbrainz:master.

@MonkeyDo

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2018

Hello @akhilesh26,
I'm interested in merging this, but I am going to wait until we have renamed the entities (we are in the process of renaming Creator -> Author and Publication ->Edition Group).

In the meantime, I have a couple of suggestions:

  1. The table isn't currently sorted by number of entities

capture d ecran 2018-10-23 a 19 00 26

2. Could you also add the entity icon in front of each entity? We're trying to add them wherever relevant. For an example, see [the 'add' menu code](https://github.com/bookbrainz/bookbrainz-site/blob/6a409b0052daebe972dcb3d62479541c85f3d73c/src/client/containers/layout.js#L106)

@MonkeyDo MonkeyDo self-requested a review Oct 23, 2018

@akhilesh26

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

Hello @MonkeyDo , thanks for the review.
I will definitely make all the changes. I will create a pull request in a few days because I am a bit busy now.

akhilesh26 added 2 commits Feb 28, 2018
feat(statistics-page): add new table to show count of total entities
Add new table with column `Entity Type`, `Total` and
`Added in last 30 days`. In this table shows that total count of
entities in each entity type.
1. Sort the table by total number of entities.
2. Add entity icon in front of each entity.

@akhilesh26 akhilesh26 force-pushed the akhilesh26:statistics_addEntityCountTable branch from 538a0e4 to 270f64e Jan 13, 2019

@akhilesh26

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2019

Hello @MonkeyDo,
I have made required changes. Please review it.
Let me know if any further changes are required.
Thanks.

newtable

@MonkeyDo
Copy link
Contributor

left a comment

Thanks for the corrections, and thanks for the addition fo this table, I think that works well, and it's very nice to have that information clearly visible.

@MonkeyDo MonkeyDo merged commit 19321db into bookbrainz:master Jan 15, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 41.441%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.