Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relationships): add initial relationship when entity created via another entity. #BB-266 #247

Merged
merged 3 commits into from Jan 31, 2019

Conversation

@akhilesh26
Copy link
Contributor

commented Jan 29, 2019

  1. add initial relationship when creating edition via publication.
  2. add initial relationship when creating edition via the publisher.
  3. add functionality to create work via creator or author with the initial relationship.

Improvements

Functionality to create work from the creator to resolve #BB-266.
Add initial relationship between publication and edition when we create edition via publication.
Add initial relationship between publisher and edition when we create edition via the publisher.

Solution

Functionality to create work from the creator to resolve #BB-266.
Add initial relationship between publication and edition when we create edition via publication.
Add initial relationship between publisher and edition when we create edition via the publisher.

Creator Page
addwork_from_creator

Creator -> Work
workeditor_with_initial_relationship

Publication -> Edition
edition_editor_from_publication

Publisher -> Edition
edition_editor_from_publisher

Areas of Impact

src/client/entity-editor/relationship-editor/actions.js
src/server/helpers/entityRouteUtils.js
src/server/routes/entity/edition.js
src/server/routes/entity/work.js```
feat(relationships): add initial relationship when entity created via…
… another entity.

1. add initial relationship when creating edition via publication.
2. add initial relationship when creating edition via the publisher.
3. add functionality to create work via creator or author with the initial relationship
@coveralls

This comment has been minimized.

Copy link

commented Jan 29, 2019

Coverage Status

Coverage decreased (-0.3%) to 40.954% when pulling 6742fb9 on akhilesh26:add_work_from_creator into a0357b5 on bookbrainz:master.

@MonkeyDo
Copy link
Contributor

left a comment

This is good. It's a great addition, and with ticket BB-326 it will simplify the creation workflow a lot.

I'll need to update the FAQ to say that you can create the author, then from the author page add a work, then from the work page add an edition (And once BB-257 is completed an edition group will be created automatically if none is defined in the form)
Thanks !

src/server/routes/entity/edition.js Outdated Show resolved Hide resolved
src/server/helpers/entityRouteUtils.js Outdated Show resolved Hide resolved
src/server/helpers/entityRouteUtils.js Outdated Show resolved Hide resolved
src/client/components/pages/entities/creator.js Outdated Show resolved Hide resolved
@akhilesh26

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

@MonkeyDo Thanks for reviewing this PR. I did the changes mentioned by you. Review the changes when you have time. Any further changes also welcomed.

@MonkeyDo
Copy link
Contributor

left a comment

That's great, working nicely and well legible. Nicely done !

@MonkeyDo MonkeyDo merged commit 7ebedf7 into bookbrainz:master Jan 31, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.3%) to 40.954%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.