Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rate_limiter): add basic rate limiter, slow down the response af… #300

Open
wants to merge 1 commit into
base: master
from

Conversation

@akhilesh26
Copy link
Contributor

commented Aug 19, 2019

…ter some limitation

This will prevent over server from DOS attacks and control the request traffic

Slow Down configurations are only, for example, We can update those after a discussion on IRC.

Problem

Sever may slow or down on high request traffic.

Solution

Implemented request slow down with configuration. To implement this express-slow-down is used.

Areas of Impact

Server-side

feat(rate_limiter): add basic rate limiter, slow down the response af…
…ter some limitation

This will prevent over server from DOS attacks and control the request traffic
@coveralls

This comment has been minimized.

Copy link

commented Aug 19, 2019

Coverage Status

Coverage increased (+0.06%) to 43.179% when pulling 8813afb on akhilesh26:rate_limiter into bdf0bb4 on bookbrainz:master.

@MonkeyDo

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

This look sane and easy to configure, good work!
I tested locally and it's working great.

I need to discuss with other team members what the limits should be, and also do some test as to how to deploy it before I merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.