Cache favicons instead of fetching from Google at every page view

[jcharaoui]

Please have Bookie cache favicons instead of fetching them from Google every time a page is displayed.

[anarcat]

in fact, why are they at google in the first place?

[mitechie]

So the favicons are through google because they provide the lookup for the pages. Google runs them through a CDN and if you reload the page and watch the network developer tools you should see the favicons loaded from the cache. This was the most performant way to display them as they're from a different network, don't hit browser number of connection limits as fast, and Google CDNs a lot better than I can.

The screenshot belows shows them showing from the cache.

[anarcat]

uh, well the point here would be to not rely on google for content. isn't that the point of a "self hosted solution"?

i understand you may make that policy decision for your hosted service, but please provide this as an option for people that want to host that content themselves.

[mitechie]

anarcat, sure thing. I'm open to a bug to either turn off or change the source of the favicons. The self hosted solution doesn't rely on them for data. It degrades nicely. This bug was filed about caching those icons which I demonstrated they are cached. Please file a new issue for other concerns and thanks for the feedback.

[mitechie]

Just to further make sure I express that I do appreciate the self hosted concerns and did take them into account when I added the feature.

• The favicons only specify a domain to google (so doesn't leak your bookmark urls)
• They're not required for UX (not click targets/etc)
• They're made to be performant using their cache.
• They're not tied to any stored data so losing them does not jeopardize anything that you might want backed up and such.

[jcharaoui]

I'm sorry, I might not have been clear in my original post : by "have Bookie cache" I mean have Bookie serve the favicons from it's database, same as the article content is saved into Bookie's database. The app can tell the browser to cache the icons, that's fine, but my main issue is that I think Bookie should be able to serve them from its own database.

[mitechie]

jcharaoui ok I'll reopen this as a bug to host favicons. I think the first step will just be a config option in the ini to just not display them at first. Thanks for updating the issue.

[anarcat]

thanks!