Skip to content
Permalink
Browse files

shipper: disable resyncs by default

This has been a long time coming. See #77 [1] and #78 [2] for the
whole saga.

Now that *all* of the know issues with running Shipper with disabled
reyncs have been fixed, we firmly believe that it's beneficial for this
to be the default. On a busy cluster, this makes shipper run much
faster, as it's not constantly re-processing state that hasn't changed,
so it has more time to process actual changes, driving latency much,
much lower.

Users that for some reason still require shipper to use resyncs are
still able to configure it through the `-resync` argument, and we intend
on supporting that for the moment.

[1] #77
[2] #78
  • Loading branch information
juliogreff committed Oct 2, 2019
1 parent cf88149 commit 4c479aa560c2b65b6cc48544562705ed18b9be2e
Showing with 1 addition and 3 deletions.
  1. +1 −1 cmd/shipper/main.go
  2. +0 −2 kubernetes/shipper.deployment.yaml
@@ -57,7 +57,7 @@ var controllers = []string{
}

const defaultRESTTimeout time.Duration = 10 * time.Second
const defaultResync time.Duration = 30 * time.Second
const defaultResync time.Duration = 0 * time.Second

var (
masterURL = flag.String("master", "", "The address of the Kubernetes API server. Overrides any value in kubeconfig. Only required if out-of-cluster.")
@@ -32,8 +32,6 @@ spec:
- "/etc/webhook/certs/tls.key"
- "-webhook-port"
- "9443"
- "-resync"
- "10m"
- "-v"
- "4"
- "-logtostderr"

0 comments on commit 4c479aa

Please sign in to comment.
You can’t perform that action at this time.