Skip to content
Permalink
Browse files

validating webhook: validate only create/update (#113)

We're not interested in validating deletes at this point. Additionally,
the webhook code doesn't currently handle those very well, failing with:

	Error from server: admission webhook "shipper.booking.com"
	denied the request: unexpected end of JSON input
  • Loading branch information...
juliogreff authored and icanhazbroccoli committed Jul 8, 2019
1 parent d1f0095 commit 6e7354161d37d2e42e499392b046fe32f7ddb03f
Showing with 2 additions and 1 deletion.
  1. +2 −1 cmd/shipperctl/configurator/cluster.go
@@ -424,7 +424,8 @@ func (c *Cluster) CreateValidatingWebhookConfiguration(caBundle []byte, namespac
Rules: []admissionregistrationv1beta1.RuleWithOperations{
admissionregistrationv1beta1.RuleWithOperations{
Operations: []admissionregistrationv1beta1.OperationType{
admissionregistrationv1beta1.OperationAll,
admissionregistrationv1beta1.Create,
admissionregistrationv1beta1.Update,
},
Rule: admissionregistrationv1beta1.Rule{
APIGroups: []string{shipper.SchemeGroupVersion.Group},

0 comments on commit 6e73541

Please sign in to comment.
You can’t perform that action at this time.